no-unsafe-query

CWE: CWE-89 OWASP: A03:2021 – Injection

Detects SQL injection in Knex raw queries. This rule is part of eslint-plugin-knex-security.

💼 This rule is set to error in the recommended config.

Quick Summary

Rule Details

Reports three shapes when they reach a raw-SQL sink:

1. String concatenation — knex.raw('SELECT ... ' + value)
2. Template interpolation — knex.raw(`SELECT ... ${value}`)
3. A variable tainted by either, including via +=, then passed to a sink

Sinks

knex.raw() and .raw() on a query builder.

❌ Incorrect

await knex.raw(`SELECT * FROM users WHERE id = ${userId}`);

await knex.raw('SELECT * FROM users WHERE email = ' + email);

let sql = 'SELECT * FROM products WHERE 1=1';
sql += ` AND name = '${name}'`;
await knex.raw(sql);

✅ Correct

knex.raw('SELECT * FROM users WHERE id = ?', [userId]);

Known limitations

• Only identifier member access is matched, so knex['raw'](...) is a false negative.
• Taint tracking is single-scope and name-based — it does not follow a query string across function boundaries.

Implementation

The detection is shared across the driver plugins via createSqlInjectionRule in @interlace/eslint-devkit; this rule supplies Knex's sinks and remediation copy. Install the plugin matching your stack and you get exactly one finding per line.

Further Reading

• Knex — parameterized queries
• OWASP — SQL Injection
• CWE-89